This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Ansible support on the Magician. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rambleraptor
pushed a commit
that referenced
this pull request
Sep 21, 2018
<!-- This change is generated by MagicModules. --> /cc @rambleraptor
modular-magician
pushed a commit
that referenced
this pull request
Feb 27, 2019
…3PAR device (ansible#39656) * Added storage modules and unit tests Removed unnecessary file Fixing pep8 issues Adding reusable documentation to the data fragment file Fixing issues reported by module validation in documentation Fixed issues: 10549, 10553 Fixed unit tests Added future imports and removed license from init py file Resolved import issue reported by ansible sanity test Fixed unit tests Adding CPG management module Fixing sanity test issues Resolving line ending issues Resolved import issue reported by ansible sanity test Correcting the error message when resource is more than 31 char Update hpe3par_cpg.py Fix for defect 10556: Unable to modify volume. Persona not set Fix for defect 10556: Unable to modify volume. Persona not set Fixing pep8 changes Fixed pep8 issues Added more pep8 related fixes Added more pep8 related fixes Fixed rebase issue in cps test Adding GPL3.0+ License (#7) * Update hpe3par.py * Update hpe3par_cpg.py * Update hpe3par_cpg.py Adding GPLV3+ only license Fix anity test Addressing review comments Fixing undefined variable error Addressed review comments and added more unit tests (#8) Added maintainers Fixed sanity test Update test_hpe3par_cpg.py Renamed the module as per the review comments (#9) * Added maintainers * Renaming the module to remove the vendor name from the module * remove pep8 related issues Modify the requirements to add version of 3par sdk Review address (#10) * Unit is no longer a different paramter in the task * Fixing unit tests * Taking into account the default values Fixing issue with default values fixing unit test Adding more flexibility and checks to the size and it's units Fixed pylint extra line issue Fixing conflicts in BOTMETA.yml Made changes according to the review comments Updating ansible version Refactored the code to move reusable method to module utils Modified the GPLv3+ license text according to the review comments. Modified the module utils license to BSD Corrected the BOTMETA entry. Fixed the pep8 issues Fixing entries in BOTMETA.yml Removed ansible version, renamed the version to address the name review comments Reverting name change for module to revert test failures Set size and raid type and now reuqired together based on the review comment Fixed unit tests Removing default value as raid and set size are now required together Renaming the modules to ss_3par_* Resolving the pep8 issues Added storage modules and unit tests Removed unnecessary file Fixing pep8 issues Adding reusable documentation to the data fragment file Fixing issues reported by module validation in documentation Fixed issues: 10549, 10553 Fixed unit tests Added future imports and removed license from init py file Resolved import issue reported by ansible sanity test Fixed unit tests Adding CPG management module Fixing sanity test issues Resolving line ending issues Resolved import issue reported by ansible sanity test Correcting the error message when resource is more than 31 char Update hpe3par_cpg.py Fix for defect 10556: Unable to modify volume. Persona not set Fix for defect 10556: Unable to modify volume. Persona not set Fixing pep8 changes Fixed pep8 issues Added more pep8 related fixes Added more pep8 related fixes Fixed rebase issue in cps test Adding GPL3.0+ License (#7) * Update hpe3par.py * Update hpe3par_cpg.py * Update hpe3par_cpg.py Adding GPLV3+ only license Fix anity test Addressing review comments Fixing undefined variable error Addressed review comments and added more unit tests (#8) Added maintainers Fixed sanity test Update test_hpe3par_cpg.py Renamed the module as per the review comments (#9) * Added maintainers * Renaming the module to remove the vendor name from the module * remove pep8 related issues Modify the requirements to add version of 3par sdk Review address (#10) * Unit is no longer a different paramter in the task * Fixing unit tests * Taking into account the default values Fixing issue with default values fixing unit test Adding more flexibility and checks to the size and it's units Fixed pylint extra line issue Fixing conflicts in BOTMETA.yml Made changes according to the review comments Updating ansible version Refactored the code to move reusable method to module utils Modified the GPLv3+ license text according to the review comments. Modified the module utils license to BSD Corrected the BOTMETA entry. Fixed the pep8 issues Removed ansible version, renamed the version to address the name review comments Reverting name change for module to revert test failures Set size and raid type and now reuqired together based on the review comment Fixed unit tests Removing default value as raid and set size are now required together Renaming the modules to ss_3par_* Resolving the pep8 issues Update lib/ansible/modules/storage/hpe3par/ss_3par_cpg.py Co-Authored-By: farhan7500 <farhan7500@gmail.com> Update lib/ansible/modules/storage/hpe3par/ss_3par_cpg.py Co-Authored-By: farhan7500 <farhan7500@gmail.com> Fixed rebase issue Fixed rebase issuein BOTMETA.yml * Modified the documentation based on the review comments * Fixed the pep8 sanity issue * Moved the doc fragment file based on latest changes * Reverting inadvertent rebase changes * Fixed inadvertent change during rebase
rambleraptor
pushed a commit
that referenced
this pull request
May 21, 2019
<!-- This change is generated by MagicModules. --> /cc @rambleraptor
modular-magician
added a commit
that referenced
this pull request
Sep 5, 2019
<!-- This change is generated by MagicModules. --> /cc @rambleraptor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @rambleraptor